Skip to content

docs(dotnet): add Proxy Server troubleshooting #13438

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 23, 2025

Conversation

Flash0ver
Copy link
Member

@Flash0ver Flash0ver commented Apr 17, 2025

DESCRIBE YOUR PR

Add troubleshooting entry when using Proxy Servers. Impacts all .NET SDKs.
See also getsentry/sentry-dotnet#4118

IS YOUR CHANGE URGENT?

  • Urgent deadline (GA date, etc.):
  • Other deadline:
  • None: Not urgent, can wait up to 1 week+

PRE-MERGE CHECKLIST

Make sure you've checked the following before merging your changes:

  • Checked Vercel preview for correctness, including links
  • PR was reviewed and approved by any necessary SMEs (subject matter experts)
  • PR was reviewed and approved by a member of the Sentry docs team

Copy link

vercel bot commented Apr 17, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
sentry-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 23, 2025 3:20pm
2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
changelog ⬜️ Ignored (Inspect) Visit Preview Apr 23, 2025 3:20pm
develop-docs ⬜️ Ignored (Inspect) Visit Preview Apr 23, 2025 3:20pm

Copy link
Contributor

@coolguyzone coolguyzone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for updating, LGTM!

```csharp
(SentryOptions options) =>
{
options.HttpProxy = new WebProxy("read the proxy's address from your Configuration");
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When you pass a string parameter to the WebProxy constructor, it's supposed to be the URI or address right? So something like:

new WebProxy("http://contoso")

The sample code above feels a bit misleading... I think either we show some code demonstrating how to read the proxy address from config and then feed that into the WebProxy constructor or wereturn new WebProxy("http://contoso");just demonstrate passing in a URI (maybe with a comment saying people need to replace this with the URI of the proxy server on their network).

Copy link
Member Author

@Flash0ver Flash0ver Apr 23, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the feedback. Changed to a valid Uri address.
Since these are general troubleshooting notes, I wanted to avoid using e.g. Microsoft.Extensions.Configuration, so I kept the comment vague.

Do we have a placeholder URL that we commonly use in our docs?

Copy link

codecov bot commented Apr 23, 2025

Bundle Report

Changes will decrease total bundle size by 15 bytes (-0.0%) ⬇️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
sentry-docs-server-cjs 11.14MB -9 bytes (-0.0%) ⬇️
sentry-docs-client-array-push 9.47MB -6 bytes (-0.0%) ⬇️

Affected Assets, Files, and Routes:

view changes for bundle: sentry-docs-server-cjs

Assets Changed:

Asset Name Size Change Total Size Change (%)
1729.js -3 bytes 1.75MB -0.0%
../instrumentation.js -3 bytes 1.08MB -0.0%
9523.js -3 bytes 1.05MB -0.0%
view changes for bundle: sentry-docs-client-array-push

Assets Changed:

Asset Name Size Change Total Size Change (%)
static/chunks/pages/_app-*.js -3 bytes 868.7kB -0.0%
static/chunks/8165-*.js -3 bytes 410.1kB -0.0%
server/middleware-*.js 5.55kB 6.55kB 555.3% ⚠️
server/middleware-*.js -5.55kB 1.0kB -84.74%
static/1yLDNmZw95LZcDa57jXi8/_buildManifest.js (New) 578 bytes 578 bytes 100.0% 🚀
static/1yLDNmZw95LZcDa57jXi8/_ssgManifest.js (New) 77 bytes 77 bytes 100.0% 🚀
static/HZcJQynS-*.js (Deleted) -77 bytes 0 bytes -100.0% 🗑️
static/HZcJQynS-*.js (Deleted) -578 bytes 0 bytes -100.0% 🗑️

@jamescrosswell jamescrosswell merged commit 90d1aa3 into master Apr 23, 2025
15 checks passed
@jamescrosswell jamescrosswell deleted the docs/dotnet/troubleshoot-proxy branch April 23, 2025 20:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants