-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
docs(dotnet): add Proxy Server troubleshooting #13438
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
2 Skipped Deployments
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for updating, LGTM!
```csharp | ||
(SentryOptions options) => | ||
{ | ||
options.HttpProxy = new WebProxy("read the proxy's address from your Configuration"); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When you pass a string parameter to the WebProxy constructor, it's supposed to be the URI or address right? So something like:
new WebProxy("http://contoso")
The sample code above feels a bit misleading... I think either we show some code demonstrating how to read the proxy address from config and then feed that into the WebProxy
constructor or wereturn new WebProxy("http://contoso");just demonstrate passing in a URI (maybe with a comment saying people need to replace this with the URI of the proxy server on their network).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the feedback. Changed to a valid Uri
address.
Since these are general troubleshooting notes, I wanted to avoid using e.g. Microsoft.Extensions.Configuration
, so I kept the comment vague.
Do we have a placeholder URL that we commonly use in our docs?
Bundle ReportChanges will decrease total bundle size by 15 bytes (-0.0%) ⬇️. This is within the configured threshold ✅ Detailed changes
Affected Assets, Files, and Routes:view changes for bundle: sentry-docs-server-cjsAssets Changed:
view changes for bundle: sentry-docs-client-array-pushAssets Changed:
|
DESCRIBE YOUR PR
Add troubleshooting entry when using Proxy Servers. Impacts all .NET SDKs.
See also getsentry/sentry-dotnet#4118
IS YOUR CHANGE URGENT?
PRE-MERGE CHECKLIST
Make sure you've checked the following before merging your changes: